fix(auth): preserve 'custom' provider instead of silently mapping to openrouter#2725
Closed
amethystani wants to merge 1 commit into
Closed
fix(auth): preserve 'custom' provider instead of silently mapping to openrouter#2725amethystani wants to merge 1 commit into
amethystani wants to merge 1 commit into
Conversation
…openrouter normalize_provider() grouped 'custom' and 'openrouter' together and returned 'openrouter' for both. Users who set provider: custom in config.yaml would silently have their provider switched to openrouter mid-session with no warning or error message. Split the single set check into two explicit returns so that 'openrouter' stays 'openrouter' and 'custom' stays 'custom'.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize_provider()inauth.pygrouped'custom'and'openrouter'in a single set check and returned'openrouter'for both. Users who setprovider: custominconfig.yamlwould silently have their provider switched toopenroutermid-session with no warning, error message, or any indication that the switch happened.Root Cause
hermes_cli/auth.pyline 693:Fix
Split the single set check into two explicit returns:
Impact
One-line surgical fix. Users who set
provider: custom(local LLMs, custom OpenAI-compatible endpoints) will no longer have their provider silently overridden.Closes #2562