feat(cli): show FULL ACCESS / RESTRICTED ACCESS label in welcome banner#2721
Closed
amethystani wants to merge 1 commit into
Closed
feat(cli): show FULL ACCESS / RESTRICTED ACCESS label in welcome banner#2721amethystani wants to merge 1 commit into
amethystani wants to merge 1 commit into
Conversation
Add a FULL ACCESS / RESTRICTED ACCESS label to the welcome banner so users can immediately see whether tool approvals are active. - FULL ACCESS (red, ⚠) when --yolo flag or approvals.mode=off is set - RESTRICTED ACCESS (green, ✓) in default (manual approval) mode Adds yolo_mode parameter to build_welcome_banner(); cli.py reads it from HERMES_YOLO_MODE env var or the approvals.mode config key.
Collaborator
1 similar comment
Collaborator
Contributor
|
Automated hermes-sweeper review: this PR is superseded by the implementation already on current main. Evidence:
Thanks for the contribution — the underlying UX issue is covered on main now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a permissions mode indicator to the welcome banner so users immediately know whether tool approvals are active when Hermes starts.
Changes
hermes_cli/banner.pyyolo_mode: bool = Falseparameter tobuild_welcome_banner()yolo_mode=True: show⚠ FULL ACCESS — tool approvals bypassedin red✓ RESTRICTED ACCESS — tool approvals enabledin greencli.pyHERMES_YOLO_MODEenv var orapprovals.mode == "off"config keyyolo_modetobuild_welcome_banner()Impact
Small cosmetic addition to the banner. No behavioral changes. Helps users running with
--yoloorapprovals.mode: offimmediately see their permission state without checking config.Closes #2663