Skip to content

feat(acp): add session edit auto-approval modes#27034

Closed
HenkDz wants to merge 5 commits into
NousResearch:mainfrom
HenkDz:feat/acp-session-edit-auto-approve
Closed

feat(acp): add session edit auto-approval modes#27034
HenkDz wants to merge 5 commits into
NousResearch:mainfrom
HenkDz:feat/acp-session-edit-auto-approve

Conversation

@HenkDz

@HenkDz HenkDz commented May 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Moves Zed edit auto-approval controls from ACP config options to ACP modes so the model picker remains visible.
  • Maps Default, Accept Edits, and Don't Ask modes onto the existing edit approval policy backend.
  • Shows the structured edit diff on the tool-start card for auto-approved edits, where no approval card exists.
  • Keeps manual approval mode compact so the approval card remains the canonical diff surface.

Stack note

This is a follow-up in the ACP/Zed edit approval stack and is intended to sit after the edit approval diff PR.

Test plan

  • scripts/run_tests.sh tests/acp/test_server.py tests/acp/test_tools.py tests/acp/test_edit_approval.py -q --tb=short

@cardtest15-coder

This comment was marked as spam.

@alt-glitch alt-glitch added type/feature New feature or request P2 Medium — degraded but workaround exists comp/acp Agent Communication Protocol adapter comp/tools Tool registry, model_tools, toolsets labels May 16, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Salvaged onto current main via #27862, merged as 0292398. Your 5 commits were cherry-picked with authorship preserved — git log on main shows you as author of all five. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/acp Agent Communication Protocol adapter comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants