fix(auxiliary): preserve named provider on custom endpoint#26909
Open
LeonSGP43 wants to merge 1 commit into
Open
fix(auxiliary): preserve named provider on custom endpoint#26909LeonSGP43 wants to merge 1 commit into
LeonSGP43 wants to merge 1 commit into
Conversation
Collaborator
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes auxiliary provider resolution so
auxiliary.<task>.provideris preserved whenbase_urlandapi_keyare both configured. Previously this path forced provider to"custom", which skipped provider-specific handling in downstream call logic.Related Issue
Fixes #26879
Type of Change
Changes Made
_resolve_task_provider_model()inagent/auxiliary_client.py:cfg_base_url+cfg_api_keyare both set, preserve explicit non-autocfg_providerinstead of forcing"custom".tests/agent/test_vision_resolved_args.py:provider: autostill resolves to"custom"for this pathHow to Test
python3 -m pytest -o addopts='' tests/agent/test_vision_resolved_args.pyset
auxiliary.vision.provider=zaiwithbase_url+api_keyand confirm resolved provider remainszai.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
4 passed in 0.63s