fix: prevent stale memory overwrites on session reset (#2670)#2675
Closed
devorun wants to merge 1 commit into
Closed
fix: prevent stale memory overwrites on session reset (#2670)#2675devorun wants to merge 1 commit into
devorun wants to merge 1 commit into
Conversation
) Fixes NousResearch#2670. **The Issue:** The gateway's memory flush mechanism spawns a temporary agent to review old conversation history when a session resets or the gateway restarts. This flush agent lacks awareness of recent memory changes (e.g., from cron jobs or concurrent sessions), causing it to silently overwrite live memory with stale context. **The Fix:** This PR addresses the root cause by adding two critical safeguards to `_flush_memories_for_session`: 1. **Cron Session Bypass:** Completely skips memory flushes for headless cron sessions (`startswith("cron_")`), as they have no valid conversation history to summarize. 2. **Opt-out Configuration:** Allows users to explicitly disable the flush agent via `memory.flush_on_reset: false` in `config.yaml`, enabling manual memory management without unpredictable reversions.
Contributor
|
Merged via #2687. Your cron session bypass idea was incorporated directly — cherry-picked onto current main with attribution preserved. The salvage PR also added live memory injection into the flush prompt (so the flush agent can see what's already saved and avoid overwrites). Thanks for identifying the cron flush path as a problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2670.
The Issue:
The gateway's memory flush mechanism spawns a temporary agent to review old conversation history when a session resets or the gateway restarts. This flush agent lacks awareness of recent memory changes (e.g., from cron jobs or concurrent sessions), causing it to silently overwrite live memory with stale context.
The Fix:
This PR addresses the root cause by adding two critical safeguards to
_flush_memories_for_session:startswith("cron_")), as they have no valid conversation history to summarize.memory.flush_on_reset: falseinconfig.yaml, enabling manual memory management without unpredictable reversions.What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs