fix(config): log warning instead of silently swallowing config.yaml errors#2673
Closed
sprmn24 wants to merge 1 commit into
Closed
fix(config): log warning instead of silently swallowing config.yaml errors#2673sprmn24 wants to merge 1 commit into
sprmn24 wants to merge 1 commit into
Conversation
…rrors A bare `except Exception: pass` meant any YAML syntax error, bad value, or unexpected structure in config.yaml was silently ignored and the gateway fell back to .env / gateway.json without any indication. Users had no way to know why their config changes had no effect. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a silent failure in
gateway/config.pywhere the entire config.yaml processing block (lines 411-517) is wrapped inexcept Exception: pass. Any YAML syntax error, file permission issue, or unexpected data shape is silently swallowed — users see no error and have no idea why their config changes have no effect.Type of Change
Changes Made
gateway/config.py: Replaced bareexcept Exception: passwithexcept Exception as e: logger.warning(...)that logs:No new imports needed —
logger = logging.getLogger(__name__)was already defined at the top of the file.How to Test
~/.hermes/config.yaml(e.g. add a stray:or unbalanced quotes)hermes gatewaypython3 -m pytest tests/ -qChecklist
Code
fix(scope):,feat(scope):, etc.)Documentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
N/A — logging change, no UI impact.