Skip to content

fix(kanban): preserve dashboard text casing#26420

Closed
aqilaziz wants to merge 3 commits into
NousResearch:mainfrom
aqilaziz:fix/kanban-dashboard-normal-case
Closed

fix(kanban): preserve dashboard text casing#26420
aqilaziz wants to merge 3 commits into
NousResearch:mainfrom
aqilaziz:fix/kanban-dashboard-normal-case

Conversation

@aqilaziz

@aqilaziz aqilaziz commented May 15, 2026

Copy link
Copy Markdown
Contributor

Fixes #26408

Summary:

  • reset inherited dashboard uppercase styling at the Kanban plugin boundary
  • remove forced uppercase transforms from Kanban drawer labels, dependency labels, edit links, run outcome labels, and metadata labels
  • keep task IDs, task titles, profile IDs, paths, and user-entered content rendered with their stored casing
  • add a regression test that checks the Kanban CSS opts out of inherited uppercase and avoids forcing uppercase on these Kanban UI surfaces
  • include CI test stabilizers for the existing Discord mock and Nous provider parity failures

Tests:

  • python -m pytest -o addopts= tests\plugins\test_kanban_dashboard_plugin.py::test_dashboard_kanban_preserves_user_entered_case -q --tb=short
  • python -m pytest -o addopts= tests\e2e\test_discord_adapter.py -q --tb=short
  • python -m pytest -o addopts= tests\run_agent\test_provider_parity.py::TestDeveloperRoleSwap::test_developer_role_via_nous_portal tests\run_agent\test_provider_parity.py::TestBuildApiKwargsNousPortal::test_includes_nous_product_tags tests\run_agent\test_provider_parity.py::TestBuildApiKwargsNousPortal::test_uses_chat_completions_format -q --tb=short
  • python -m ruff check tests\plugins\test_kanban_dashboard_plugin.py tests\e2e\conftest.py tests\run_agent\test_provider_parity.py

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists labels May 15, 2026
@alt-glitch

alt-glitch commented May 15, 2026

Copy link
Copy Markdown
Collaborator

Duplicate of #26413 — both fix #26408 (kanban dashboard ALL-CAPS). #26413 was filed first and also modifies index.js; this PR overlaps on style.css and adds tests. Maintainer should pick one.

@aqilaziz

aqilaziz commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the pointer. I’ll leave this open as an alternate with regression coverage for the CSS path, but I’m fine with maintainers taking #26413 instead and closing this if that lands first.

@aqilaziz aqilaziz force-pushed the fix/kanban-dashboard-normal-case branch from 9d07224 to e037cfd Compare May 15, 2026 22:44
@aqilaziz aqilaziz mentioned this pull request May 16, 2026
Closed
@austinpickett austinpickett requested a review from Copilot May 18, 2026 14:13
@austinpickett

austinpickett commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Please use PULL_REQUEST_TEMPLATE.md

Copilot AI reviewed May 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses dashboard-inherited ALL-CAPS styling in the Kanban dashboard plugin so case-sensitive/user-entered text is rendered with its original casing, and adds a regression test to prevent uppercase transforms from creeping back in. It also includes small test adjustments for Nous-provider parity and a robustness tweak in gateway PATH discovery.

Changes:

  • Reset inherited text-transform at the Kanban plugin boundary and remove uppercase transforms from several Kanban UI label surfaces.
  • Add a regression test that inspects the built Kanban CSS to ensure it opts out of inherited uppercase and doesn’t reintroduce text-transform: uppercase on key selectors.
  • Adjust provider parity tests to pass the model at agent construction time for Nous portal tests; harden gateway PATH directory checks against OSError.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
plugins/kanban/dashboard/dist/style.css Resets inherited casing and removes uppercase styling from Kanban UI selectors.
tests/plugins/test_kanban_dashboard_plugin.py Adds CSS regression coverage ensuring Kanban doesn’t force uppercase.
tests/run_agent/test_provider_parity.py Updates Nous portal parity tests to pass model into _make_agent.
hermes_cli/gateway.py Avoids crashes when checking candidate PATH dirs by handling OSError from Path.is_dir().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/plugins/test_kanban_dashboard_plugin.py
Comment on lines +168 to +170
start = css.index(selector)
open_brace = css.index("{", start)
close_brace = css.index("}", open_brace)
@teknium1

teknium1 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Thanks @aqilaziz — closing as superseded. Dashboard text-casing fixes have landed on main via 4414a99d8 fix(kanban): stop forcing dashboard text to all caps (#26413) and b8bf2f8 fix(kanban): merge dashboard batch QOL with i18n + collapse + assignee-casing. Same outcome. Appreciate the contribution!

@teknium1 teknium1 closed this May 19, 2026
@alt-glitch alt-glitch mentioned this pull request May 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[UX]: Kanban WebUI forced ALL-CAPS styling reduces readability and obscures exact task/profile text

5 participants

@aqilaziz @alt-glitch @austinpickett @teknium1