fix: Remove unavailable deepseek-chat model from static provider list#26280
Closed
AllynSheep wants to merge 2 commits into
Closed
fix: Remove unavailable deepseek-chat model from static provider list#26280AllynSheep wants to merge 2 commits into
AllynSheep wants to merge 2 commits into
Conversation
The deepseek-chat model is no longer available in the DeepSeek API, but it was still listed in the static _PROVIDER_MODELS catalog. This caused users to see the model in the TUI menu but get an error when trying to switch to it. This fix removes deepseek-chat from the deepseek provider's static model list, keeping only the currently available models: - deepseek-v4-pro - deepseek-v4-flash - deepseek-reasoner Fixes NousResearch#26269
Add allynsheep@users.noreply.github.com to the AUTHOR_MAP in scripts/release.py to fix the check-attribution CI failure.
Collaborator
Contributor
Author
|
Closing this PR in favor of #26278, which provides a more comprehensive solution that not only removes deepseek-chat but also adds a _DEPRECATED_MODEL_REDIRECTS mechanism for future model deprecations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #26269 where users could see and select the
deepseek-chatmodel in the TUI but got an error when trying to switch to it.Problem
The
deepseek-chatmodel was listed in the static_PROVIDER_MODELS["deepseek"]catalog, but it is no longer available in the actual DeepSeek API. This caused:deepseek-chatin the TUI model selection menudeepseek-chatwas not found in this provider's model listing. Similar models:deepseek-v4-flash,deepseek-v4-pro"Root Cause
The static model catalog in
hermes_cli/models.pycontained outdated model names that don't match the current DeepSeek API offering.Solution
Removed
deepseek-chatfrom the_PROVIDER_MODELS["deepseek"]list, keeping only the currently available models:deepseek-v4-prodeepseek-v4-flashdeepseek-reasonerChanges
hermes_cli/models.py: Removeddeepseek-chatfrom the deepseek provider's static model list (1 line change)Testing
Verified that the fix works correctly:
deepseek-chatno longer appears in the static model listdeepseek-v4-pro,deepseek-v4-flash,deepseek-reasoner) are still availableImpact
This is a minimal, focused fix that only touches the model catalog. It removes a model that was already unavailable from the API, so there's no functional regression - users simply won't see an option that didn't work anyway.
Fixes #26269