fix(cli): preserve tab completion inside space-containing paths#26230
Open
LeonSGP43 wants to merge 1 commit into
Open
fix(cli): preserve tab completion inside space-containing paths#26230LeonSGP43 wants to merge 1 commit into
LeonSGP43 wants to merge 1 commit into
Conversation
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes CLI path completion after completing into a directory whose name contains
spaces. Hermes now keeps the full path token under the cursor instead of
dropping the earlier path segment, so repeated Tab presses can continue
completing inside directories like
./My Documents/.Related Issue
Fixes #26223
Type of Change
Changes Made
hermes_cli/commands.pyso_extract_path_word()returns the nearest path-like token chain ending at thecursor, including space-separated directory segments.
tests/hermes_cli/test_path_completion.pyfor
_extract_path_word()and repeated Tab completion inside a directory withspaces.
How to Test
python3 -m pytest -o addopts='' tests/hermes_cli/test_path_completion.pyMy Documentsregression tests.hermes:type
edit ./My, press Tab to complete a directory like./My Documents/,then press Tab again and verify nested files are suggested.
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs