fix(delegate): preserve completed status and interrupt pending children#25982
Open
thakoreh wants to merge 1 commit into
Open
fix(delegate): preserve completed status and interrupt pending children#25982thakoreh wants to merge 1 commit into
thakoreh wants to merge 1 commit into
Conversation
68572d7 to
dbc3ba0
Compare
Collaborator
7660872 to
e0a2679
Compare
e0a2679 to
4ff4ede
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completedstatus for child agents that finish normally with an emptyfinal_responsechild.interrupt()when the parent is interruptedFixes #25819
Test Plan
python -m pytest tests/tools/test_delegate_interrupt_status.py -qpython -m pytest tests/tools/test_delegate_interrupt_status.py tests/tools/test_delegate_subagent_timeout_diagnostic.py tests/tools/test_delegate_composite_toolsets.py -q