fix: preserve runtime credentials in background review fork#2581
Closed
mwotton wants to merge 1 commit into
Closed
fix: preserve runtime credentials in background review fork#2581mwotton wants to merge 1 commit into
mwotton wants to merge 1 commit into
Conversation
This was referenced Apr 25, 2026
Contributor
|
Thanks for this contribution, @mwotton! The bug you identified is real and well-described. This is an automated hermes-sweeper review. The fix has since been independently implemented and merged to
Closing as implemented on main. |
Collaborator
|
Superseded by #16099 (merged) which fixes the same root cause — background review fork inheriting parent's live runtime credentials. |
Collaborator
|
Superseded by #16099 (merged) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The background review fork only inherited
modelandprovider. For custom OpenAI-compatible routes like Local Qwen, Hermes stores the transport provider asopenrouter, so the fork would fall back tohttps://openrouter.ai/api/v1with no API key.Testing
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 PYTHONPATH=/home/mark/.hermes/hermes-agent-bg-review /home/mark/.hermes/hermes-agent/venv/bin/pytest -c /dev/null /home/mark/.hermes/hermes-agent-bg-review/tests/test_background_review_runtime.py -qpython -m py_compile /home/mark/.hermes/hermes-agent-bg-review/run_agent.py