Skip to content

fix(gateway): enable text-intercept for multi-choice clarify fallback (#25587)#25778

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-65abd7c4
May 14, 2026
Merged

fix(gateway): enable text-intercept for multi-choice clarify fallback (#25587)#25778
teknium1 merged 1 commit into
mainfrom
hermes/hermes-65abd7c4

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Multi-choice clarify prompts on platforms that don't support inline buttons (Mattermost, generic webhook) need text-intercept fallback so the user can type their answer. The text-fallback path was missing the mark_awaiting_text() call, so subsequent text messages weren't routed to the open clarify.

Adds the missing call inside the text-fallback path of base.send_clarify plus a regression test.

Closes #25567.

Salvage of #25587 by @zccyman.

@teknium1 teknium1 merged commit f26098e into main May 14, 2026
@teknium1 teknium1 deleted the hermes/hermes-65abd7c4 branch May 14, 2026 14:59
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-65abd7c4 vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 8339 on HEAD, 8339 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4387 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery labels May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: clarify multiple-choice text fallback never intercepts user reply on Mattermost

3 participants