fix(gateway): load streaming config from nested gateway.streaming key#25694
Closed
luyao618 wants to merge 1 commit into
Closed
fix(gateway): load streaming config from nested gateway.streaming key#25694luyao618 wants to merge 1 commit into
luyao618 wants to merge 1 commit into
Conversation
`hermes config set gateway.streaming.*` writes the streaming block nested under a `gateway:` key in config.yaml, but the config loader only checked for a top-level `streaming:` key — silently ignoring the nested variant. Fall back to `yaml_cfg['gateway']['streaming']` when the top-level key is absent, matching the pattern already used for other nested config sections. Closes NousResearch#25676
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix silent config drop when streaming is configured via
hermes config set gateway.streaming.*.Problem
hermes config set gateway.streaming.enabled truewrites the streaming block nested under agateway:key inconfig.yaml:But
load_gateway_config()(line 737) only checked for a top-levelstreaming:key — silently ignoring the nested variant. Users following thetelegram.mddocs hit this and got no streaming with zero diagnostics.Fix
In
gateway/config.py, fall back toyaml_cfg["gateway"]["streaming"]when the top-level key is absent. Top-level still takes precedence when both exist. This matches the existing pattern for other nested config sections (e.g.platforms).Test
Added
tests/test_gateway_streaming_nested_config.pywith 3 cases:All 3 pass. Existing test suite unaffected.
Closes #25676