fix(clarify): set awaiting_text=True for all clarify entries including multiple-choice#25610
Closed
alaamohanad169-ship-it wants to merge 2 commits into
Closed
Conversation
The _approval_callback method in HermesCLI (cli.py) hardcoded timeout = 60
instead of reading the approvals.timeout config value. This meant the config
setting was silently ignored for CLI interactive approval prompts.
One-line change: replace timeout = 60 with
timeout = int(CLI_CONFIG.get("approvals", {}).get("timeout", 60)).
Other approval paths (tools/approval.py and hermes_cli/callbacks.py) already
read the config correctly.
…g multiple-choice When choices were provided, awaiting_text was set to False, which meant get_pending_for_session() would never match the entry for text-fallback adapters like Mattermost. The user's typed reply was never intercepted, causing the agent to block until timeout. Button-based adapters (e.g. Telegram) resolve via resolve_gateway_clarify directly and don't check awaiting_text, so they're unaffected. Now awaiting_text is always True so both button and text-fallback paths work.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Mattermost, clarify with multiple choices renders a numbered list but the user reply is never intercepted because awaiting_text was False when choices were provided. Now awaiting_text is always True.