Fix duplicate Slack final replies after stream finalize failure#25258
Closed
guglielmofonda wants to merge 1 commit into
Closed
Fix duplicate Slack final replies after stream finalize failure#25258guglielmofonda wants to merge 1 commit into
guglielmofonda wants to merge 1 commit into
Conversation
Contributor
|
This appears to be implemented on current Automated hermes-sweeper review evidence:
The implementation uses a broader delivery-confirmation flag rather than the PR's proposed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat.update/finalize edit fails transiently._visible_matches_final()to confirm the visible streamed body equals the cleaned final response before suppressing the normal gateway fallback send.Fixes #25256
Test plan
python -m pytest tests/gateway/test_stream_consumer.py::TestFinalizeDuplicateSuppression -qpython -m pytest tests/gateway/test_stream_consumer.py tests/gateway/test_stream_consumer_draft.py -q