fix(gateway): dynamically detect virtualenv path in systemd unit generation (#2492)#2518
Closed
devorun wants to merge 1 commit into
Closed
fix(gateway): dynamically detect virtualenv path in systemd unit generation (#2492)#2518devorun wants to merge 1 commit into
devorun wants to merge 1 commit into
Conversation
…ration (NousResearch#2492) ## What does this PR do? Fixes the hardcoded `venv/` directory reference in `hermes_cli/gateway.py` when generating the systemd unit. It dynamically detects the active virtual environment using `sys.prefix` and properly checks for `.venv` as a fallback, preventing `PATH` and `VIRTUAL_ENV` from pointing to a nonexistent directory. ## Related Issue Fixes NousResearch#2492 ## Type of Change - [x] 🐛 Bug fix (non-breaking change that fixes an issue) - [ ] ✨ New feature (non-breaking change that adds functionality) ## Changes Made - Updated `get_python_path()` to dynamically check for both `.venv` and `venv`. - Updated `generate_systemd_unit()` to prioritize `sys.prefix` and fallback to existing virtual environments instead of hardcoding `venv/`. ## Checklist - [x] I've read the Contributing Guide - [x] My commit messages follow Conventional Commits - [x] My PR contains only changes related to this fix
This was referenced Mar 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ration (#2492)
What does this PR do?
Fixes the hardcoded
venv/directory reference inhermes_cli/gateway.pywhen generating the systemd unit. It dynamically detects the active virtual environment usingsys.prefixand properly checks for.venvas a fallback, preventingPATHandVIRTUAL_ENVfrom pointing to a nonexistent directory.Related Issue
Fixes #2492
Type of Change
Changes Made
get_python_path()to dynamically check for both.venvandvenv.generate_systemd_unit()to prioritizesys.prefixand fallback to existing virtual environments instead of hardcodingvenv/.Checklist
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs