fix(gateway): stop HASS_TOKEN from overriding enabled: false#25089
Open
ms-alan wants to merge 1 commit into
Open
fix(gateway): stop HASS_TOKEN from overriding enabled: false#25089ms-alan wants to merge 1 commit into
ms-alan wants to merge 1 commit into
Conversation
When HASS_TOKEN is set, it previously unconditionally set platforms.homeassistant.enabled = True, overriding an explicit enabled: false in the user's config.yaml. Now enabled = True is only set when creating a brand-new PlatformConfig (i.e. when HOMEASSISTANT was not already in config). If the user already configured the platform (even with enabled: false), the env var only sets the token/URL but leaves enabled untouched. Closes NousResearch#25065
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When HASS_TOKEN is set, it previously unconditionally set platforms.homeassistant.enabled = True, overriding an explicit enabled: false in the user's config.yaml.
Now enabled = True is only set when creating a brand-new PlatformConfig (i.e., when HOMEASSISTANT was not already in config). If the user already configured the platform (even with enabled: false), the env var only sets the token/URL but leaves enabled untouched.
Closes #25065