fix(bedrock): call lazy_deps.ensure before importing boto3#25088
Closed
ms-alan wants to merge 1 commit into
Closed
fix(bedrock): call lazy_deps.ensure before importing boto3#25088ms-alan wants to merge 1 commit into
ms-alan wants to merge 1 commit into
Conversation
.require_boto3() now calls lazy_deps.ensure('provider.bedrock') before
attempting to import boto3. Without this, a fresh install that has
boto3 as a lazy dep would produce a cryptic ImportError instead of
triggering the lazy installation flow.
Closes NousResearch#24967
Collaborator
19 tasks
Contributor
|
This has been implemented on current Automated hermes-sweeper review evidence:
Thanks for the focused fix. The behavior is already present on main, so this PR can be closed as implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.require_boto3() now calls lazy_deps.ensure('provider.bedrock') before attempting to import boto3. Without this, a fresh install that has boto3 as a lazy dep would produce a cryptic ImportError instead of triggering the lazy installation flow.
Fix
agent/bedrock_adapter.py: Call lazy_deps.ensure('provider.bedrock') inside _require_boto3() before the import boto3 line. This matches the pattern used by other lazy-dep providers.
Closes #24967