feat: docker_extra_args, message timestamps, and lazy skill loading#2420
Closed
Mibayy wants to merge 1 commit into
Closed
feat: docker_extra_args, message timestamps, and lazy skill loading#2420Mibayy wants to merge 1 commit into
Mibayy wants to merge 1 commit into
Conversation
Three independent quality-of-life improvements: **docker_extra_args** (terminal.docker_extra_args / TERMINAL_DOCKER_EXTRA_ARGS) Allows users to pass extra flags verbatim to docker run, appended after the hardcoded security defaults. Useful for adding capabilities (e.g. --cap-add SETUID for packages that need setuid binaries) or any other docker run option not exposed by existing config keys. Entries are validated as strings; non-strings are logged and skipped. **display.timestamps** When true, appends [HH:MM] to user input labels and the assistant response box header. Off by default. Covers all input variants: plain text, multiline, and pasted content. **display.lazy_skills** When true, replaces the full skill index in the system prompt with a single-line note telling the model to call skills_list() on demand. Saves tokens on every session for users with large skill libraries who only use a subset per task. Off by default for backward compatibility. Closes NousResearch#1569
12 tasks
Contributor
|
Salvaged the two opt-in QoL bits ( Thanks for the PRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent quality-of-life improvements, all opt-in and backward compatible.
1.
terminal.docker_extra_argsPass extra flags verbatim to
docker run, appended after the hardcoded security defaults.Also available via
TERMINAL_DOCKER_EXTRA_ARGS='["--cap-add","SETUID"]'. Entries are validated as strings; non-strings are logged and skipped. Useful for apt packages that need capabilities not granted by the default--cap-drop ALL+ minimal re-adds, or any otherdocker runflag not exposed by existing config keys.2.
display.timestampsAppends
[HH:MM]to user input labels and the assistant response box header.Covers all input variants: plain text, multiline, and pasted content. Off by default.
Closes #1569
3.
display.lazy_skillsWhen enabled, replaces the full skill index in the system prompt with a single-line note telling the model to call
skills_list()on demand, thenskill_view(name)to load the one it needs.Saves tokens every session for users with large skill libraries who only use a subset per task. The index can grow to hundreds of lines — this collapses it to ~3 lines regardless of skill count. Off by default.
Closes #2045
Test plan
docker_extra_args: ["--cap-add", "SETUID"]appears indocker runcommanddisplay.timestamps: trueshows[HH:MM]on user and assistant labelsdisplay.lazy_skills: truereplaces skill index with count + instructionfalse/[]with no behavior change