fix(homeassistant): coerce watch_all instead of bool()#24053
Open
kronexoi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes Home Assistant
watch_allparsing when the config value is a quoted string.Previously,
watch_all: "false"was interpreted viabool(...), which evaluates any non-empty string asTrue. That caused the Home Assistant adapter to treat"false"as enabled and forward events that should have been dropped when no explicit filters were configured.What changed
bool(extra.get("watch_all", False))withis_truthy_value(..., default=False)"false"at initialization time"false"does not allow unfiltered event forwardingRepro
With config equivalent to:
platforms:
homeassistant:
extra:
watch_all: "false"
the adapter previously behaved as if watch_all were enabled.
Testing
pytest tests/gateway/test_homeassistant.py -q -k "watch_all"
4 passed in 4.52s