fix(gateway): validate user authorization before auto-resume#23800
Open
ygd58 wants to merge 1 commit into
Open
fix(gateway): validate user authorization before auto-resume#23800ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
Auto-resume of restart-interrupted sessions bypassed auth checks — the session owner's user_id was never validated against TELEGRAM_ALLOWED_USERS before the synthetic resume event was dispatched. An attacker who had an active session before TELEGRAM_ALLOWED_USERS was configured could receive a full agent response on gateway restart (issue NousResearch#23778). Fix: check _is_callback_user_authorized() for the session owner before scheduling auto-resume. Sessions whose owner is no longer in the allowlist are skipped with a warning log. Fixes NousResearch#23778 (partial - auto-resume auth bypass)
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Auto-resume of restart-interrupted sessions bypassed auth checks. The session owner was never validated against
TELEGRAM_ALLOWED_USERSbefore the synthetic resume event was dispatched. An attacker with an active session before the allowlist was configured could receive a full agent response on gateway restart.Fix
Check
_is_callback_user_authorized()for the session owner before scheduling auto-resume. Unauthorized sessions are skipped with a warning log.Follows up on #23795 (inbound message auth bypass).
Fixes #23778 (partial - auto-resume auth bypass)