fix(tools): forward media args through live adapter#23770
Open
LeonSGP43 wants to merge 1 commit into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the live in-process
_send_via_adapter()path so gateway adapters receivemedia_filesandforce_documentjust like the existing standalone sender path. Before this change, attachments could silently disappear whenever the gateway runner and adapter lived in the current process.Related Issue
Fixes #23760
Type of Change
Changes Made
media_filesandforce_documentthrough the liveadapter.send(...)call in/tools/send_message_tool.py/tests/tools/test_send_message_tool.pythat exercises the live in-process adapter path and asserts both kwargs are preservedHow to Test
uv run --frozen pytest -q -o addopts='' tests/tools/test_send_message_tool.py -k TestSendViaAdapterStandaloneFallbacktest_live_adapter_forwards_media_kwargspassesuv run --frozen ruff check tools/send_message_tool.py tests/tools/test_send_message_tool.pyChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
uv run --frozen pytest -q -o addopts='' tests/tools/test_send_message_tool.py -k TestSendViaAdapterStandaloneFallback->6 passeduv run --frozen ruff check tools/send_message_tool.py tests/tools/test_send_message_tool.py-> passed