Skip to content

fix(auxiliary): raise default compression timeout#23752

Open
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:codex/22986-codex-compression-timeout
Open

fix(auxiliary): raise default compression timeout#23752
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:codex/22986-codex-compression-timeout

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

What does this PR do?

Raises the default auxiliary compression timeout from 120s to 300s so large Codex/compression passes are less likely to self-timeout and get retried as noisy connection failures.

Related Issue

Fixes #22986

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • increased DEFAULT_CONFIG["auxiliary"]["compression"]["timeout"] from 120 to 300
  • clarified the inline config comment so the longer timeout is explicitly tied to large-context / slower cloud backends
  • added a regression assertion for the default timeout in tests/hermes_cli/test_aux_config.py
  • updated the reset-preserves-timeouts expectation to the new default

How to Test

  1. Run uv run --frozen pytest -q -o addopts='' tests/hermes_cli/test_aux_config.py
  2. Confirm DEFAULT_CONFIG["auxiliary"]["compression"]["timeout"] == 300
  3. Run hermes model / reset-aux flows and confirm compression timeout stays at the new default unless a user has overridden it

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: macOS 15 / arm64

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

  • uv run --frozen pytest -q -o addopts='' tests/hermes_cli/test_aux_config.py22 passed
  • uv run --frozen ruff check hermes_cli/config.py tests/hermes_cli/test_aux_config.py → passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent loop, run_agent.py, prompt builder P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

2 participants