fix(api-server): apply non-vision image fallback#23743
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
19 tasks
Contributor
|
This looks implemented on current Evidence:
Thanks for the focused fix and regression coverage here; the behavior this PR targeted has landed on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the provider-profile
chat_completionspath so non-vision models still run Hermes' shared image fallback before transport kwargs are built. Without this,/v1/chat/completionscan forward rawimage_urlparts to non-vision models and trigger 400s even though the legacy path already strips or describes those images.Related Issue
Fixes #23733
Type of Change
Changes Made
/run_agent.pyso the provider-profilechat_completionsbranch calls_prepare_messages_for_non_vision_model(...)beforebuild_kwargs(...)/tests/run_agent/test_run_agent.pythat proves the provider-profile path now forwards transformed non-vision messages instead of raw multimodal payloads/tests/gateway/test_api_server_multimodal.pyto verify the API server multimodal path still behaves correctly end to endHow to Test
uv run --frozen ruff check run_agent.py tests/run_agent/test_run_agent.pyuv run --frozen pytest -q -o addopts='' tests/run_agent/test_run_agent.py -k 'provider_profile_applies_non_vision_fallback or converts_multimodal_user_image_to_text or reuses_cached_image_analysis_for_duplicate_images'uv run --frozen pytest -q -o addopts='' tests/gateway/test_api_server_multimodal.pyChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
3 passed, 321 deselected23 passed347 tests collected