fix(cli): remove return from voice finally block#23654
Open
LeonSGP43 wants to merge 1 commit into
Open
Conversation
Collaborator
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
returnfrom thefinallyblock in Hermes voice cleanup so Python 3.14+ no longer emits aSyntaxWarning, while preserving the existing continuous-voice restart behavior.Related Issue
Fixes #21088
Type of Change
Changes Made
/Users/leongong/Desktop/LeonProjects/worktrees/hermes-agent/hermes-21088-voice-finally/cli.pyso post-cleanup voice restart logic runs afterfinallyreturnin_voice_stop_and_transcribewith astop_continuousflag that preserves the 3x no-speech stop rule/Users/leongong/Desktop/LeonProjects/worktrees/hermes-agent/hermes-21088-voice-finally/tests/tools/test_voice_cli_integration.pyto assert thefinallyblock no longer contains areturnHow to Test
uv run --frozen --extra dev pytest -q -o addopts='' tests/tools/test_voice_cli_integration.py -k 'voice_stop_and_transcribe_has_no_return_in_finally'PYTHONWARNINGS='error::SyntaxWarning' uv run --frozen python -m py_compile cli.pyuv run --frozen ruff check cli.py tests/tools/test_voice_cli_integration.pyChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs
uv run --frozen --extra dev pytest -q -o addopts='' tests/tools/test_voice_cli_integration.py -k 'voice_stop_and_transcribe_has_no_return_in_finally'->1 passedPYTHONWARNINGS='error::SyntaxWarning' uv run --frozen python -m py_compile cli.py-> passeduv run --frozen ruff check cli.py tests/tools/test_voice_cli_integration.py->All checks passed!