feat(homeassistant): support notify service delivery#23643
Open
BlackishGreen33 wants to merge 2 commits into
Open
feat(homeassistant): support notify service delivery#23643BlackishGreen33 wants to merge 2 commits into
BlackishGreen33 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional Home Assistant notify.<service> delivery for outbound gateway messages so agent responses can be routed to mobile push notify services (while keeping persistent_notification.create as the default).
Changes:
- Read
platforms.homeassistant.extra.notify_serviceandHASS_NOTIFY_SERVICE, and normalizenotify.<service>vs<service>. - Route
HomeAssistantAdapter.send()to/api/services/notify/<service>when configured; otherwise keep/api/services/persistent_notification/create. - Add unit + integration test coverage and update Home Assistant messaging docs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
gateway/platforms/homeassistant.py |
Adds notify-service configuration + routing logic for outbound REST sends. |
gateway/config.py |
Adds HASS_NOTIFY_SERVICE env override into HA platform config. |
tests/gateway/test_homeassistant.py |
Adds unit tests for notify-service normalization and send() routing. |
tests/integration/test_ha_integration.py |
Adds integration test verifying notify service calls hit the notify endpoint. |
tests/conftest.py |
Ensures HASS_NOTIFY_SERVICE is treated as a credential-like env var for test isolation. |
website/docs/user-guide/messaging/homeassistant.md |
Documents HASS_NOTIFY_SERVICE and notify_service config option + behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
CI note after checking logs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23136
Problem:
Home Assistant gateway responses only used persistent_notification.create, so mobile push notify services could not receive agent replies.
Implementation:
Tests:
This change is intentionally narrow: it does not change inbound HA event handling or the default persistent notification behavior.