fix: use TUI modal for slash confirmations#23571
Closed
zhengyn0001 wants to merge 1 commit into
Closed
Conversation
1 task
Contributor
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CLI slash confirmation prompts such as /new, /clear, /undo, and /reload-mcp when running inside the prompt_toolkit TUI.
Previously these confirmations used raw text input, which could race with prompt_toolkit stdin ownership. In some terminals this caused:
Choice [1/2/3]:to appear before the option labels/newto reportcancelled (no input)This changes slash confirmations to use a prompt_toolkit-native modal with:
The raw
_prompt_text_input()path remains as a fallback for non-interactive or edge cases.Tests
/Users/Zhuanz/.hermes/hermes-agent/venv/bin/python -m pytest tests/cli/test_destructive_slash_confirm.py tests/cli/test_prompt_text_input_thread_safety.py -q -o 'addopts='Result: