fix(auxiliary): fall back to env when openrouter pool is exhausted#23495
Open
LeonSGP43 wants to merge 1 commit into
Open
fix(auxiliary): fall back to env when openrouter pool is exhausted#23495LeonSGP43 wants to merge 1 commit into
LeonSGP43 wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the OpenRouter auxiliary client fallback path so a cooled-down/exhausted credential pool no longer blocks
OPENROUTER_API_KEYfrom being used. This keeps auxiliary tasks on the expected env-var fallback path instead of returning(None, None)early.Related Issue
Fixes #23452
Type of Change
Changes Made
agent/auxiliary_client.pyso_try_openrouter()only returns the pool-backed client when a usable pooled key existsOPENROUTER_API_KEYenv lookup when the pool exists but currently has no selectable entrytests/agent/test_auxiliary_client.pycovering the exhausted-pool + env-fallback caseHow to Test
uv run --frozen pytest -q -o addopts='' tests/agent/test_auxiliary_client.py -k 'openrouter and (pool_exhausted or env_keeps_not_set_warning or falls_back_to_env)'uv run --frozen ruff check agent/auxiliary_client.py tests/agent/test_auxiliary_client.pyenv -i HOME="$HOME" PATH="$PATH" TERM="${TERM:-xterm-256color}" UV_CACHE_DIR="$HOME/.cache/uv" uv run --frozen pytest -q -o addopts='' --collect-only tests/agent/test_auxiliary_client.py -k 'openrouter and (pool_exhausted or env_keeps_not_set_warning or falls_back_to_env)'Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
4 passed, 138 deselectedruff check: passed4 tests collectedpytest tests/ -qwas not used as the merge gate here because the same cleanorigin/mainbaseline currently shows unrelated collection failures outside this change scope