fix(doctor): use ?key= auth for Gemini API key validation#23364
Closed
uzunkuyruk wants to merge 1 commit into
Closed
fix(doctor): use ?key= auth for Gemini API key validation#23364uzunkuyruk wants to merge 1 commit into
uzunkuyruk wants to merge 1 commit into
Conversation
_probe_apikey_provider uses Authorization: Bearer for all providers,
but Google's generativelanguage.googleapis.com requires key= as a
query parameter instead. Bearer auth always returns HTTP 401 on the
/v1beta/models endpoint even for a valid key, so doctor falsely
reported Gemini keys as invalid.
Fix: detect generativelanguage.googleapis.com URLs and switch to
params={"key": key} auth, matching the Gemini REST API contract.
Fixes NousResearch#23354
53c70e8 to
67b3a06
Compare
Collaborator
This was referenced May 13, 2026
Contributor
|
Closing as superseded by #11961. Triage notes (high confidence): Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen. (Bulk-closed during a CLI PR triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_probe_apikey_providerusesAuthorization: Bearerfor all providers, but Google'sgenerativelanguage.googleapis.comrequires the API key as a?key=query parameter. Sending a Bearer token to/v1beta/modelsalways returns HTTP 401 — even for a perfectly valid key — causinghermes doctorto falsely report Gemini credentials as invalid.Fix: before firing the health-check request, detect URLs pointing to
generativelanguage.googleapis.comand switch toparams={"key": key}auth, matching the Gemini REST API contract. All other providers continue through the existing Bearer path unchanged.Type of Change
References
Fixes #23354
Checklist