fix(kanban): treat archived parent tasks as terminal for dependency resolution#23325
Closed
Ninso112 wants to merge 3 commits into
Closed
fix(kanban): treat archived parent tasks as terminal for dependency resolution#23325Ninso112 wants to merge 3 commits into
Ninso112 wants to merge 3 commits into
Conversation
… platforms Gateway auto-title generation is fire-and-forget housekeeping. When it fails (e.g. auxiliary provider HTTP 401/402), the error was surfaced as a user-visible chat message via _emit_auxiliary_failure. Failures are already logged at WARNING level in generate_title() and visible in gateway.log, so operators can still diagnose issues. Fixes NousResearch#23246.
…rompt_toolkit 3.0.52+ prompt_toolkit 3.0.52+ changed run_in_terminal() to return an Awaitable. Four call sites in cli.py invoke it fire-and-forget because the callback is scheduled on the already-running event loop and executes correctly. Without awaiting, Python 3.10+ emits a RuntimeWarning that gets caught by the process_loop error handler and logged as noise. Suppress the warning at each call site with warnings.catch_warnings() since the callback semantics are unchanged — the function still runs on the event loop thread. Fixes NousResearch#23297.
…esolution When a parent task is archived, dependent child tasks were stuck in todo forever because recompute_ready and claim_task only checked for status == 'done'. Now both functions also treat 'archived' as a terminal status, allowing children to proceed when their parent is archived. Fixes NousResearch#23180.
Collaborator
|
Merged via salvage PR #23791. Your commits were cherry-picked onto current main with your authorship preserved in git log. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
todoforever when their parent task is archivedrecompute_readyandclaim_tasknow treatarchivedas a terminal status alongsidedone, allowing children to proceed when their parent is archived== 'done'/!= 'done'toIN ('done', 'archived')/NOT IN ('done', 'archived')Why
When a parent task is archived, its dependent children should be allowed to proceed — the parent is no longer going to complete, so waiting for it would strand the children indefinitely. This is the simplest fix that preserves the existing dependency resolution semantics without adding interactive prompts.
Fixes #23180.