fix(agent): bypass credential-pool guard for billing errors in eager fallback#23323
Open
liuhao1024 wants to merge 3 commits into
Open
fix(agent): bypass credential-pool guard for billing errors in eager fallback#23323liuhao1024 wants to merge 3 commits into
liuhao1024 wants to merge 3 commits into
Conversation
…INSTALL_TIMEOUT Increase the default npm install timeout for WhatsApp bridge from 60s to 300s (5 minutes) to accommodate slower systems like Unraid NAS. Make it configurable via WHATSAPP_NPM_INSTALL_TIMEOUT environment variable for users who need even longer timeouts. Closes NousResearch#14980
- Add 'path', 'old_string', 'new_string', and 'patch' to required list - Update description to clarify mode-specific parameter requirements - This addresses issue where LLMs would omit these parameters because they were not marked as required in the schema, even though they are required depending on the mode Fixes NousResearch#15524
…fallback When the primary provider returns HTTP 402 (credit exhaustion), the eager-fallback path was blocked by _pool_may_recover_from_rate_limit() when a multi-entry credential pool existed. For billing errors, credential rotation cannot help — it is an account-level issue, not a per-key rate limit. The pool rotation in _recover_with_credential_pool() already attempted all entries before reaching this point. Skip the pool-recovery check for FailoverReason.billing so the fallback provider activates on the first 402 instead of burning through retries. Fixes NousResearch#23138
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the primary provider returns HTTP 402 (credit exhaustion), the eager-fallback path is blocked by
_pool_may_recover_from_rate_limit()when a multi-entry credential pool exists. This causes the agent to burn through all retries against a depleted provider instead of immediately switching to the configured fallback.Related Issue
N/A
Type of Change
Changes Made
How to Test
pytest tests/ -q— all tests should passChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture and workflows — or N/A