Skip to content

fix(terminal): clarify configured execution environment#23242

Open
iacker wants to merge 1 commit into
NousResearch:mainfrom
iacker:fix/issue-7672-terminal-tool-description-v2
Open

fix(terminal): clarify configured execution environment#23242
iacker wants to merge 1 commit into
NousResearch:mainfrom
iacker:fix/issue-7672-terminal-tool-description-v2

Conversation

@iacker

@iacker iacker commented May 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Validation

  • python -m pytest tests/tools/test_terminal_tool_description.py -q -n 0
  • python -m pytest tests/tools/test_terminal_tool.py tests/tools/test_terminal_tool_description.py -q -n 0

Replaces #8364.

@iacker

iacker commented May 10, 2026

Copy link
Copy Markdown
Contributor Author

Post-create CI note:

  • Local targeted validation passed (tests/tools/test_terminal_tool.py + tests/tools/test_terminal_tool_description.py).
  • Current Windows footguns (blocking) failure is outside this PR diff: it reports tools/process_registry.py:588 (os.killpg(..., signal.SIGKILL)), which this PR does not touch.
  • ruff + ty diff reports no new ruff/ty issues, but its comment-post step hit GitHub Actions integration permissions (Resource not accessible by integration).
  • e2e failed early; logs were not available while the test workflow was still in progress at the time of this note.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have tool/terminal Terminal execution and process management labels May 10, 2026
@iacker

iacker commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

Additional CI triage note (2026-05-12 cron):

  • e2e failures are in tests/e2e/test_platform_commands.py session reset assertions (/new not calling runner.session_store.reset_session), not in the PR diff (tools/terminal_tool.py, tests/tools/test_terminal_tool_description.py).
  • ruff + ty diff reports 0 new Ruff issues and 0 new ty issues; the job fails while trying to post the lint summary comment (Resource not accessible by integration).
  • Windows footguns (blocking) still points to pre-existing tools/process_registry.py:588, outside this PR diff.

Keeping the PR scope narrow unless maintainers ask to address repository-wide failures here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have tool/terminal Terminal execution and process management type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants