fix(langfuse): reject placeholder credentials#23188
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
19 tasks
3 tasks
Collaborator
|
Thanks @LeonSGP43 — closing as a duplicate of #23831 (now landed via salvage #26320). Both PRs target the same bug (#22763 / #23823: placeholder Langfuse credentials silently drop traces). The differentiating choice was approach:
The whitelist approach catches strictly more cases — values like Sorry for the missed credit — your PR predates #23831 by 1 day and reflects real diagnostic work. Closing here for hygiene; the issue is now fixed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Detects obvious placeholder Langfuse credentials and fails loudly instead of silently treating the plugin as configured.
Related Issue
Fixes #22763
Type of Change
Changes Made
plugins/observability/langfuse/__init__.pytests/plugins/test_langfuse_plugin.pywith a regression test for placeholder credentialsHow to Test
UV_PYTHON=3.11 /Library/Frameworks/Python.framework/Versions/3.10/bin/uv run --frozen pytest -q -o addopts='' tests/plugins/test_langfuse_plugin.pyUV_PYTHON=3.11 /Library/Frameworks/Python.framework/Versions/3.10/bin/uv run --frozen ruff check plugins/observability/langfuse/__init__.py tests/plugins/test_langfuse_plugin.py_get_langfuse()returnsNoneand logs a warning whenLANGFUSE_PUBLIC_KEY/LANGFUSE_SECRET_KEYare placeholder valuesChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
8 passed in 0.59sruff checkpassed for the touched Langfuse files