fix(gateway): suppress noisy chat lifecycle notices#23119
Closed
Quisharoo wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces “status noise” from the gateway on chat platforms by filtering out compression-related lifecycle updates (which otherwise arrive as standalone messages), while keeping those notices available in non-chat contexts. It also prevents the webhook GitHub-comment delivery path from posting a literal SKIP sentinel as a comment.
Changes:
- Added gateway-side suppression for compression-related
lifecyclestatus messages on Telegram/Discord. - Updated GitHub comment delivery to treat a literal
SKIPresponse as “no-op deliver”. - Added targeted tests covering both the status suppression behavior and the
SKIPsentinel suppression.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
gateway/run.py |
Adds a helper + filtering in the status callback to suppress compression lifecycle notices for Telegram/Discord. |
gateway/platforms/webhook.py |
Suppresses literal SKIP agent output for github_comment delivery to avoid posting it as a PR comment. |
tests/gateway/test_gateway_status_noise.py |
New unit tests validating which lifecycle messages are suppressed/retained by platform and event type. |
tests/gateway/test_webhook_integration.py |
Adds an integration test ensuring SKIP does not invoke gh pr comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add persistent action requests and Telegram callback support for webhook-delivered action cards. Local action handlers, such as Colm's Sentry Create PR flow, register at runtime via plugins instead of living in Hermes core.
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKIPwebhook responses for GitHub comment delivery instead of posting the sentinel as a commentTest Plan
scripts/run_tests.sh tests/gateway/test_gateway_status_noise.py tests/gateway/test_webhook_integration.py -q