fix(compression): use extract_content_or_reasoning for thinking models (supersedes #19007)#23047
Open
shellybotmoyer wants to merge 1 commit into
Open
Conversation
When using thinking/reasoning models (DeepSeek v4, GLM-5.1, Qwen 3) via Ollama 0.22+, the compressor reads only response.choices[0].message.content which is empty when reasoning tokens consume the budget. The reasoning field holds the actual summary content. Fixes NousResearch#19003.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #19007 which had fallen behind origin/main and showed
DIRTYmerge state.What changed
The original fix in #19007 changed
agent/context_compressor.pyline 871 from:to:
Conflicts resolved
<<<<<<< HEAD ... >>>>>>>in line 26): origin/main had added_is_connection_errorto the same import line that the PR addedextract_content_or_reasoning. Resolved by keeping both imports:Original change description
No other logic was changed.
Closes #19007 (supersedes)