Review: Tests read source from a hardcoded /tmp/hermes-agent-fork/ path

Several new test files open source files from a fixed path that will not exist in CI:

# tests/hermes_cli/test_split_guard.py
with open("/tmp/hermes-agent-fork/cli.py") as f:
    source = f.read()

# tests/hermes_cli/test_banner_cprint_fallback.py
with open("/tmp/hermes-agent-fork/hermes_cli/banner.py") as f:
    source = f.read()

# tests/hermes_cli/test_gemini_doctor_probe.py
with open("/tmp/hermes-agent-fork/hermes_cli/doctor.py") as f:
    source = f.read()

Why this breaks: CI runners do not have /tmp/hermes-agent-fork/. Even locally, the directory may contain a stale checkout that does not reflect the changes in this PR. These tests will always pass on the author's machine and always fail everywhere else.

Fix options (pick one):

1. Import the module and use inspect.getsource — the most Pythonic approach:

   import inspect
   from hermes_cli import banner
   source = inspect.getsource(banner.cprint)

2. Use pathlib.Path(__file__) to locate the repo root relative to the test:

   repo_root = Path(__file__).resolve().parents[2]  # tests/hermes_cli/ → repo root
   source = (repo_root / "hermes_cli" / "banner.py").read_text()

3. Test the actual behavior instead of source text — e.g., mock _pt_print to raise and verify cprint falls back to print():

   def test_cprint_falls_back_on_error(capsys):
       with patch("hermes_cli.banner._pt_print", side_effect=Exception("no console")):
           banner.cprint("hello")
       assert "hello" in capsys.readouterr().out

Option 3 is preferred where feasible — it tests the contract, not the implementation.

The same pattern appears in PRs #23018, #23017, #23011, #23008, and #23000.

Thanks for the review. The test file in this PR (tests/cron/test_cron_load_jobs_malformed.py) does not use any hardcoded /tmp/hermes-agent-fork/ paths — it uses tempfile.TemporaryDirectory() for isolation.

The examples in your review appear to reference other PRs. If there are specific changes needed in this PR, please let me know and I'll address them promptly.

Hi @liuhao1024 — I replied to your review above confirming that the hardcoded path concern does not apply to this PR (it uses tempfile for isolation). If everything looks good, would appreciate a review or approval. Thanks! 🙏