fix(memory): derive holographic auto-extracted facts#22959
Open
MestreY0d4-Uninter wants to merge 1 commit into
Open
fix(memory): derive holographic auto-extracted facts#22959MestreY0d4-Uninter wants to merge 1 commit into
MestreY0d4-Uninter wants to merge 1 commit into
Conversation
501b853 to
f0dcedb
Compare
Contributor
Author
|
CI triage note after the latest push:
Focused validation for this PR still passes locally: python -m pytest -o addopts='' tests/plugins/memory/test_holographic_auto_extract.py -q
python -m pytest -o addopts='' tests/plugins/memory -q
ruff check plugins/memory/holographic/__init__.py tests/plugins/memory/test_holographic_auto_extract.pyI’m leaving the PR scoped to the holographic memory extraction fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes holographic memory
auto_extractso matched user messages are stored as derived facts instead of verbatim chat text.For example, a message like:
now stores:
instead of saving the full original message.
Related Issue
Fixes #22907
Type of Change
Changes Made
plugins/memory/holographic/__init__.pycontent[:400]user_pref,project)tests/plugins/memory/test_holographic_auto_extract.pyHow to Test
python -m pytest -o addopts='' tests/plugins/memory/test_holographic_auto_extract.py -qpython -m pytest -o addopts='' tests/plugins/memory -qChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
I did not run the full local suite for this small plugin change. The current upstream
Testsworkflow is already red onmain, so I kept validation focused on the affected memory plugin area.