fix: use credential_pool for custom endpoint model listing probes#22810
Closed
v1b3coder wants to merge 1 commit into
Closed
fix: use credential_pool for custom endpoint model listing probes#22810v1b3coder wants to merge 1 commit into
v1b3coder wants to merge 1 commit into
Conversation
- _resolve_named_custom_runtime now checks credential_pool for bare provider: custom with explicit_base_url (was only checking env vars) - model_switch.py removes 'if provider != custom' guard — resolved api_key is now always used, including for custom providers Fixes: NousResearch#18681, NousResearch#16254, NousResearch#12919
Contributor
|
Merged via salvage PR #22842. salvage applied your patch and re-authored to your noreply email since the original commit used 'agent@hermes.local' as a placeholder. Your authorship is now recorded in git log on main. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom endpoint model validation (/model command) was failing because:
Both are now fixed.
Fixes
Closes #18681, #16254, #12919