fix(cli): skip dedicated-check providers in apikey loop#22512
Closed
AllynSheep wants to merge 1 commit into
Closed
fix(cli): skip dedicated-check providers in apikey loop#22512AllynSheep wants to merge 1 commit into
AllynSheep wants to merge 1 commit into
Conversation
Fixes NousResearch#22346: `hermes doctor` runs duplicate health checks for providers that already have dedicated check sections (Anthropic, OpenRouter). The generic loop uses `Authorization: Bearer` header, which fails for Anthropic's required `x-api-key` header. - Add `_DEDICATED_CHECKS` set with providers that have dedicated health-check sections - Skip these providers in the `_apikey_providers` loop to avoid duplicate checks with wrong auth headers This ensures Anthropic check uses the correct `x-api-key` header via its dedicated check section.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22346:
hermes doctorruns duplicate health checks for providers that already have dedicated check sections (Anthropic, OpenRouter).Root Cause
The generic
_apikey_providersloop at line 1265 usesAuthorization: Bearerheader, which fails for Anthropic's requiredx-api-keyheader. Since Anthropic already has a dedicated check section (lines 1203-1256), the generic loop creates a duplicate check with wrong auth.Fix
Add
_DEDICATED_CHECKSset with provider names that have dedicated health-check sections. Skip these providers in the_apikey_providersloop to avoid duplicate checks with wrong auth headers.Testing
hermes doctornow shows single Anthropic API check (✓) instead of duplicate (✓ + ⚠ HTTP 404)