fix(kanban): request default board explicitly (#21819)#22106
Closed
Tranquil-Flow wants to merge 1 commit into
Closed
fix(kanban): request default board explicitly (#21819)#22106Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
Contributor
|
Merged via PR #22940 (rebase) — your commit is preserved on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the Kanban dashboard request the selected board explicitly even when the selected slug is
default. Previously some dashboard REST calls omittedboard=default, allowing the backend's current-board pointer to leak a non-default board into the UI while the selector still showed Default.Related Issue
Fixes #21819
Type of Change
Changes Made
plugins/kanban/dashboard/dist/index.js: route config and boards requests throughwithBoard(..., board)and includeboardin the create-board callback dependencies.tests/plugins/test_kanban_dashboard_plugin.py: verify the backend acceptsboard=defaultand add a static regression test that dashboard code explicitly useswithBoard(..., board)for default-sensitive requests.How to Test
python3 -m pytest tests/plugins/test_kanban_dashboard_plugin.py -k 'explicit_board_default_param or dashboard_requests_default_board_explicitly' -o 'addopts=' --tb=short -qtest_dashboard_requests_default_board_explicitlyfails.Checklist
Code
pytest tests/ -qand all tests passDocumentation & Housekeeping
cli-config.yaml.example— N/ACONTRIBUTING.mdorAGENTS.md— N/A