fix(google-chat): repair setup prompt imports#22038
Merged
teknium1 merged 1 commit intoMay 8, 2026
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Google Chat gateway setup crash caused by the plugin importing shared CLI prompt/output helpers from
hermes_cli.config. Those helpers live inhermes_cli.cli_output, so selecting Google Chat inhermes gateway setupcould raiseImportError: cannot import name 'prompt' from 'hermes_cli.config'before setup prompts were shown.This splits the imports so env helpers still come from
hermes_cli.configand prompt/output helpers come fromhermes_cli.cli_output.Related Issue
Fixes #
Type of Change
Changes Made
plugins/platforms/google_chat/adapter.py: import prompt/output helpers fromhermes_cli.cli_outputinstead ofhermes_cli.config.tests/gateway/test_google_chat.py: add a regression test forinteractive_setup()that exercises the setup prompts and env persistence path.How to Test
python -m pytest tests/gateway/test_google_chat.py -q.python -m pytest tests/gateway/test_google_chat.py::TestGoogleChatInteractiveSetup -q.hermes gateway setupand confirm setup prompts appear instead of an import error.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"— N/AScreenshots / Logs
Targeted tests:
.venv/bin/python -m pytest tests/gateway/test_google_chat.py -q: 154 passed, 1 warning in 6.89s..venv/bin/python -m pytest tests/gateway/test_google_chat.py::TestGoogleChatInteractiveSetup -q: 1 passed in 3.43s.py_compileforplugins/platforms/google_chat/adapter.pyandtests/gateway/test_google_chat.py: passed.Full suite:
scripts/run_tests.sh -n 4: 54 failed, 20926 passed, 51 skipped, 240 warnings in 495.27s.HERMES_HOMEbefore full suite: empty.HERMES_HOMEafter full suite: empty.The full suite is not green in this checkout; the targeted Google Chat tests pass in isolation after the full-suite run.
Full-suite failure summary:
tests/gateway/test_api_server_runs.py::TestRunEvents::test_approval_request_event_and_response_unblock_runtests/gateway/test_config.py::TestLoadGatewayConfig::test_bridges_quoted_false_platform_enabled_from_config_yamltests/cron/test_cron_script.py::TestBuildJobPromptWithScript::test_script_empty_output_notedtests/gateway/test_dingtalk.py::TestCardLifecycle::test_final_reply_finalizes_cardtests/gateway/test_dingtalk.py::TestCardLifecycle::test_intermediate_send_stays_streamingtests/gateway/test_dingtalk.py::TestCardLifecycle::test_done_fires_only_when_reply_to_is_settests/gateway/test_dingtalk.py::TestCardLifecycle::test_edit_message_finalize_fires_donetests/gateway/test_dingtalk.py::TestCardLifecycle::test_edit_message_finalize_false_tracks_siblingtests/gateway/test_dingtalk.py::TestCardLifecycle::test_next_send_auto_closes_sibling_streaming_cardstests/gateway/test_dingtalk.py::TestDingTalkAdapterAICards::test_send_uses_ai_card_if_configuredtests/gateway/test_discord_bot_filter.py::TestDiscordBotFilter::test_default_is_nonetests/agent/test_auxiliary_client.py::TestGetTextAuxiliaryClient::test_custom_endpoint_uses_codex_wrapper_when_runtime_requests_responses_apitests/agent/test_bedrock_1m_context.py::TestBedrockContext1MBeta::test_common_betas_includes_1mtests/agent/test_bedrock_1m_context.py::TestBedrockContext1MBeta::test_common_betas_for_native_anthropic_includes_1mtests/agent/test_bedrock_1m_context.py::TestBedrockContext1MBeta::test_build_anthropic_kwargs_includes_1m_for_bedrock_fastmodetests/gateway/test_discord_free_response.py::test_discord_free_channel_skips_auto_threadtests/cron/test_scheduler_mcp_init.py::test_run_job_calls_discover_mcp_tools_before_agent_constructiontests/cron/test_scheduler_mcp_init.py::test_run_job_tolerates_discover_mcp_tools_failuretests/agent/test_unsupported_parameter_retry.py::TestMaxTokensRetryHardening::test_sync_max_tokens_retry_matches_generic_phrasingtests/agent/test_unsupported_parameter_retry.py::TestMaxTokensRetryHardening::test_async_max_tokens_retry_matches_generic_phrasingtests/gateway/test_api_server.py::TestAdapterInit::test_default_configtests/hermes_cli/test_backup.py::TestPreUpdateBackup::test_rotation_keeps_only_ntests/hermes_cli/test_model_validation.py::TestValidateCodexAutoCorrection::test_very_different_name_falls_to_suggestionstests/gateway/test_google_chat.py::TestEnvConfigLoading::test_project_id_primarytests/gateway/test_google_chat.py::TestEnvConfigLoading::test_project_id_falls_back_to_google_cloud_projecttests/gateway/test_google_chat.py::TestEnvConfigLoading::test_subscription_accepts_legacy_aliastests/gateway/test_google_chat.py::TestEnvConfigLoading::test_sa_path_falls_back_to_google_application_credentialstests/gateway/test_google_chat.py::TestEnvConfigLoading::test_home_channel_populatedtests/gateway/test_google_chat.py::TestEnvConfigLoading::test_connected_platforms_recognises_via_extrastests/hermes_cli/test_cmd_update.py::TestCmdUpdateBranchFallback::test_update_refreshes_repo_and_tui_node_dependenciestests/run_agent/test_concurrent_interrupt.py::test_concurrent_interrupt_cancels_pendingtests/run_agent/test_concurrent_interrupt.py::test_running_concurrent_worker_sees_is_interruptedtests/hermes_cli/test_model_provider_persistence.py::TestProviderPersistsAfterModelSave::test_lmstudio_provider_saved_when_selectedtests/hermes_cli/test_model_provider_persistence.py::TestBaseUrlValidation::test_stepfun_provider_saved_with_selected_regiontests/tools/test_browser_chromium_check.py::TestChromiumInstalled::test_false_when_dir_emptytests/tools/test_browser_chromium_check.py::TestChromiumInstalled::test_false_when_only_unrelated_browserstests/tools/test_browser_chromium_check.py::TestChromiumInstalled::test_false_when_path_not_a_dirtests/tools/test_browser_chromium_check.py::TestCheckBrowserRequirementsChromium::test_local_mode_missing_chromium_returns_falsetests/tools/test_browser_chromium_check.py::TestRunBrowserCommandChromiumGuard::test_local_mode_missing_chromium_returns_error_immediatelytests/tools/test_browser_chromium_check.py::TestRunBrowserCommandChromiumGuard::test_docker_hint_mentions_image_pulltests/tools/test_browser_chromium_check.py::TestRunBrowserCommandChromiumGuard::test_non_docker_hint_mentions_agent_browser_installtests/tools/test_delegate.py::TestDelegationCredentialResolution::test_nous_provider_resolves_nous_credentialstests/tools/test_delegate.py::TestDelegationCredentialResolution::test_provider_resolution_uses_runtime_model_when_config_model_missingtests/tools/test_delegate.py::TestDelegationCredentialResolution::test_provider_resolves_full_credentialstests/tools/test_delegate.py::TestDelegateHeartbeat::test_heartbeat_still_trips_idle_stale_when_no_tooltests/tools/test_skill_provenance.py::test_default_origin_is_foregroundtests/tools/test_tirith_security.py::TestDiskFailureMarker::test_cosign_missing_marker_clears_when_cosign_appearstests/tools/test_vercel_sandbox_environment.py::TestExecute::test_execute_runs_command_from_workspace_root_and_updates_cwdtests/tools/test_command_guards.py::TestTirithBlock::test_tirith_block_gateway_returns_approval_requiredtests/tools/test_command_guards.py::TestTirithAllowDangerous::test_dangerous_only_gatewaytests/tools/test_command_guards.py::TestCombinedWarnings::test_combined_gatewaytests/tools/test_command_guards.py::TestWarnEmptyFindings::test_warn_empty_findings_gatewaytests/tools/test_credential_pool_env_fallback.py::TestCredentialPoolSeedsFromDotEnv::test_os_environ_still_wins_over_dotenvtests/tools/test_daytona_environment.py::TestExecute::test_custom_cwd_in_command_wrapper