Apply Hermes file safety rules to Copilot ACP fs handlers#2195
Closed
ifrederico wants to merge 7 commits into
Closed
Apply Hermes file safety rules to Copilot ACP fs handlers#2195ifrederico wants to merge 7 commits into
ifrederico wants to merge 7 commits into
Conversation
Contributor
|
Merged via #13391 (commit 9b36636). Your commit was cherry-picked onto current main with your authorship preserved via rebase-merge — check The branch here was 2800+ commits behind so we salvaged the substantive commit rather than rebase the whole branch. Only change to your code: the shared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HERMES_WRITE_SAFE_ROOTenforcement to ACP fs writesTesting
python -m unittest tests.agent.test_copilot_acp_client -vpython -m py_compile agent/file_safety.py agent/copilot_acp_client.py tools/file_operations.py tools/file_tools.py tests/agent/test_copilot_acp_client.py