fix(delegate): update tests broken by v0.13.0 heartbeat and credentia…#21821
Closed
MorAlekss wants to merge 1 commit into
Closed
fix(delegate): update tests broken by v0.13.0 heartbeat and credentia…#21821MorAlekss wants to merge 1 commit into
MorAlekss wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing in favor of #21012 which covers the same fixes along with other shared CI failures. |
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 4 tests in
TestDelegateHeartbeatandTestDelegationCredentialResolutionbroken by v0.13.0 changes.Root cause
Two upstream changes in v0.13.0 broke existing tests without updating them:
_HEARTBEAT_STALE_CYCLES_IDLEincreased from 5 to 15 -test_heartbeat_still_trips_idle_stale_when_no_toolhad a hardcoded bound of 9 cycles which no longer holds.resolve_runtime_provider()gained a newtarget_modelparameter - three tests inTestDelegationCredentialResolutionasserted the old signature withouttarget_model.What changed
tests/tools/test_delegate.py: replaced hardcoded9with_HEARTBEAT_STALE_CYCLES_IDLE + 2so the bound tracks the runtime constanttests/tools/test_delegate.py: updated threeassert_called_once_withassertions to includetarget_model=ANYtests/tools/test_delegate.py: addedANYtounittest.mockimportsTests
17 tests across
TestDelegateHeartbeatandTestDelegationCredentialResolutionpass. No regressions.