fix(auxiliary): recover Codex stream drops#21761
Closed
xdeepsnyx wants to merge 1 commit into
Closed
Conversation
Codex auxiliary calls must use streaming Responses API, but the adapter could fail compression on transient chunked stream drops. Add retry plus create(stream=True) fallback, preserve streamed output recovery, and cover the behavior with regression tests.
19 tasks
19 tasks
Contributor
|
This looks implemented on current main by the later Codex streaming refactor plus the shared auxiliary transient-retry path. This is an automated hermes-sweeper review. Evidence:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
responses.stream()once, then fall back toresponses.create(stream=True)because the Codex backend requires streaming.Why
Codex auxiliary clients are used by side tasks such as context compression. The main Codex chat path already has stream recovery, but the auxiliary adapter could fail on transient
incomplete chunked read/ peer-closed stream errors and force callers into fallback behavior.Test plan
./venv/bin/python -m pytest tests/agent/test_auxiliary_client.py::TestCodexAuxiliaryStreamRecovery -q -o 'addopts='./venv/bin/python -m pytest tests/agent/test_auxiliary_client.py tests/agent/test_auxiliary_transport_autodetect.py tests/agent/test_auxiliary_main_first.py -q -o 'addopts='