Skip to content

fix(profile): allow subprocess HOME override#21671

Open
nocturnum91 wants to merge 1 commit into
NousResearch:mainfrom
nocturnum91:fix/profile-subprocess-home-override
Open

fix(profile): allow subprocess HOME override#21671
nocturnum91 wants to merge 1 commit into
NousResearch:mainfrom
nocturnum91:fix/profile-subprocess-home-override

Conversation

@nocturnum91

@nocturnum91 nocturnum91 commented May 8, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Allows operators to control subprocess HOME isolation explicitly. This keeps the default isolated behavior while adding environment switches for disabling isolation or overriding the subprocess HOME path when a deployment needs a specific home directory.

Related Issue

N/A.

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • Add HERMES_PROFILE_HOME_ISOLATION=0|false|no|off support for disabling subprocess HOME isolation.
  • Add HERMES_SUBPROCESS_HOME=/path support for explicit subprocess HOME override.
  • Preserve the existing default profile-home isolation behavior.
  • Ensure HERMES_SUBPROCESS_HOME takes precedence over the isolation-disable flag.
  • Scrub the new environment variables in tests to avoid cross-test contamination.
  • Add regression coverage for default isolation, disable behavior, explicit override, and precedence.

How to Test

  1. Run subprocess HOME isolation focused tests.
  2. Run related config/environment isolation tests.
  3. Verify HERMES_SUBPROCESS_HOME precedence over HERMES_PROFILE_HOME_ISOLATION=0.
  4. Run a read-only Codex review of the final branch delta.

Verification performed during refresh:

  • uv run --extra dev pytest ... focused subprocess/profile tests: 130 passed.
  • Read-only Codex review: first BLOCKED → fixes applied → fresh final review VERDICT: CLEAN.
  • Branch was rebased onto current main and updated with --force-with-lease.

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: macOS

Note: I ran focused/regression tests locally for the changed subprocess HOME behavior and am relying on GitHub Actions for the full matrix.

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

N/A — this PR does not add a skill.

Screenshots / Logs

N/A. Relevant verification is in local focused test output, Codex review logs, and GitHub Actions checks.

@alt-glitch alt-glitch added type/feature New feature or request comp/cli CLI entry point, hermes_cli/, setup wizard area/config Config system, migrations, profiles P3 Low — cosmetic, nice to have labels May 8, 2026
@nocturnum91 nocturnum91 force-pushed the fix/profile-subprocess-home-override branch 7 times, most recently from 8aefb0e to 2ce9603 Compare May 13, 2026 17:33
@nocturnum91 nocturnum91 force-pushed the fix/profile-subprocess-home-override branch 3 times, most recently from 51d2cfd to 946a74c Compare May 16, 2026 14:04
@nocturnum91 nocturnum91 force-pushed the fix/profile-subprocess-home-override branch 5 times, most recently from 9f5d9fc to 1ed8c16 Compare May 19, 2026 12:31
@nocturnum91 nocturnum91 force-pushed the fix/profile-subprocess-home-override branch from 1ed8c16 to 4d43438 Compare May 19, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants