fix(profile): allow subprocess HOME override#21671
Open
nocturnum91 wants to merge 1 commit into
Open
Conversation
8aefb0e to
2ce9603
Compare
51d2cfd to
946a74c
Compare
9f5d9fc to
1ed8c16
Compare
1ed8c16 to
4d43438
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows operators to control subprocess HOME isolation explicitly. This keeps the default isolated behavior while adding environment switches for disabling isolation or overriding the subprocess HOME path when a deployment needs a specific home directory.
Related Issue
N/A.
Type of Change
Changes Made
HERMES_PROFILE_HOME_ISOLATION=0|false|no|offsupport for disabling subprocess HOME isolation.HERMES_SUBPROCESS_HOME=/pathsupport for explicit subprocess HOME override.HERMES_SUBPROCESS_HOMEtakes precedence over the isolation-disable flag.How to Test
HERMES_SUBPROCESS_HOMEprecedence overHERMES_PROFILE_HOME_ISOLATION=0.Verification performed during refresh:
uv run --extra dev pytest ...focused subprocess/profile tests: 130 passed.VERDICT: CLEAN.mainand updated with--force-with-lease.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passNote: I ran focused/regression tests locally for the changed subprocess HOME behavior and am relying on GitHub Actions for the full matrix.
Documentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A — this PR does not add a skill.
Screenshots / Logs
N/A. Relevant verification is in local focused test output, Codex review logs, and GitHub Actions checks.