fix(gateway): validate MEDIA: paths to reject regex patterns and placeholders#21593
Closed
liuhao1024 wants to merge 3 commits into
Closed
fix(gateway): validate MEDIA: paths to reject regex patterns and placeholders#21593liuhao1024 wants to merge 3 commits into
liuhao1024 wants to merge 3 commits into
Conversation
…INSTALL_TIMEOUT Increase the default npm install timeout for WhatsApp bridge from 60s to 300s (5 minutes) to accommodate slower systems like Unraid NAS. Make it configurable via WHATSAPP_NPM_INSTALL_TIMEOUT environment variable for users who need even longer timeouts. Closes NousResearch#14980
- Add 'path', 'old_string', 'new_string', and 'patch' to required list - Update description to clarify mode-specific parameter requirements - This addresses issue where LLMs would omit these parameters because they were not marked as required in the schema, even though they are required depending on the mode Fixes NousResearch#15524
…eholders The \S+ fallback in extract_media() regex matches non-path content (regex patterns, debug placeholders, bare words) which then get passed to os.path.exists() causing 'file not found' errors. Add path format validation after extraction: require paths to start with /, ~, or a Windows drive letter before accepting as media. Fixes NousResearch#21527
4 tasks
19 tasks
Contributor
|
Closing as implemented on main by automated hermes-sweeper review. Evidence:
The branch also carries older unrelated commits; those have main-line equivalents or safer superseding behavior, so there is no remaining change here to salvage as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
extract_media()regex ingateway/platforms/base.pyhas a\S+fallback that matches non-path content (regex patterns, debug placeholders, bare words). These invalid strings are then passed toos.path.exists()in platform adapters, causing "file not found" errors in gateway logs.Root Cause
The MEDIA tag regex (line 1354) uses a
\S+fallback alternative that matches any non-whitespace. When an LLM outputs malformed MEDIA tags — containing regex patterns like(?P<path>...), debug placeholders like<path>, or bare filenames likefilename.ogg— the fallback captures them as paths. No validation exists between extraction and downstreamos.path.exists()calls.Related Issue
N/A
Type of Change
Changes Made
How to Test
pytest tests/ -q— all tests should passChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture and workflows — or N/A