fix(whatsapp): bridge process leak + disable config asymmetry (salvage #19138)#21229
Merged
Conversation
- Add PID file mechanism to track bridge processes and kill stale ones on startup - Improve _kill_port_process() with lsof fallback when fuser is not available - Support explicit WhatsApp disable via config.yaml (whatsapp.enabled: false) - Respect WHATSAPP_ENABLED=false env var to disable WhatsApp Fixes #19124
Contributor
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19138 via salvage. Fixes #19124.
Summary
Two WhatsApp issues:
_kill_port_processrelied onfuser(missing on WSL2, minimal installs), so stale Node.js bridge processes accumulated (up to 39 observed). Addsbridge.pidPID-file tracking and anlsoffallback path.WHATSAPP_ENABLED=falsewas ignored because the code only read the env var as truthy. Both env var and YAMLwhatsapp.enabled: falsenow work symmetrically.Validation
scripts/run_tests.sh tests/gateway/ -k 'whatsapp or config'→ 462 passed.Original author: @liuhao1024.