fix(credential_pool): resolve key mix-up when custom providers share base_url (salvage #19094)#21219
Merged
Conversation
…base_url When multiple custom_providers share the same base_url but have different API keys, get_custom_provider_pool_key() always returned the first match, causing wrong-key unauthorized errors. Add provider_name parameter to prefer exact name matches over base_url-only matching, with fallback for backward compatibility. Fixes #19083
Contributor
🔎 Lint report:
|
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19094 via salvage. Fixes #19083.
Summary
When two
custom_providersshare abase_urlwith different API keys,get_custom_provider_pool_key(base_url)returns the first match in iteration order — so the second provider gets the first's credentials (401).Add optional
provider_namekwarg; prefer exact name match, fall back to base_url match for backward compat. Thread it through_try_resolve_from_custom_poolin runtime_provider at the two named-custom + openrouter-"custom" call sites.Validation
scripts/run_tests.sh tests/agent/test_credential_pool.py→ 42 passed.Original author: @shellybotmoyer.