fix(telegram): route image documents through photo handling (salvage #19023)#21173
Merged
Conversation
Contributor
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19023 via salvage.
Summary
Telegram delivers screenshots / image shares as
document(notphoto). Current code rejects them with 'Unsupported document type .png'. This salvage routes image documents through the existing photo cache + batching path.Changes
gateway/platforms/telegram.py: add image MIME/ext tables; in the document handler, detect image payloads (ext orimage/*mime) and route them viacache_image_from_bytes+_enqueue_photo_event. Move the 20 MB size check above the image branch so image documents cannot bypass it.tests/gateway/test_telegram_documents.py: regression tests for PNG and malformed image documents.Improvements during salvage
doc.mime_typeto lowercase once at the top so uppercase MIME (IMAGE/PNG) is handled symmetrically with the filename extension.Validation
scripts/run_tests.sh tests/gateway/test_telegram_documents.py→ 41 passed.Original author: @mrcoferland.