fix(gateway): log /model picker provider failures#20968
Open
LeonSGP43 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_picker_providersexceptions in the gateway/modelinteractive picker path before falling back to the text listContext
Closes #20966.
Current
mainalready accepts thecurrent_base_urlandcurrent_modelkwargs inlist_picker_providersand has coverage for that passthrough. This PR addresses the remaining silent-failure part of the issue: if the picker provider loader regresses again, the gateway no longer drops into the text list with no diagnostic trail.Verification
Result: 12 passed, 3 warnings.