Skip to content

fix(gateway): log /model picker provider failures#20968

Open
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/gateway-model-picker-failure-log
Open

fix(gateway): log /model picker provider failures#20968
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/gateway-model-picker-failure-log

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

Summary

  • log list_picker_providers exceptions in the gateway /model interactive picker path before falling back to the text list
  • keep the existing fallback behavior unchanged for Telegram/Discord users
  • add a regression test that forces the picker provider loader to raise and verifies the warning plus text fallback

Context

Closes #20966.

Current main already accepts the current_base_url and current_model kwargs in list_picker_providers and has coverage for that passthrough. This PR addresses the remaining silent-failure part of the issue: if the picker provider loader regresses again, the gateway no longer drops into the text list with no diagnostic trail.

Verification

scripts/run_tests.sh tests/gateway/test_model_command_custom_providers.py tests/hermes_cli/test_list_picker_providers.py

Result: 12 passed, 3 warnings.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/gateway Gateway runner, session dispatch, delivery labels May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/model picker silently falls back to text list (TypeError swallowed in _handle_model_command)

2 participants